Skip to content

fix: Off by one assertion for invoker property #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 4, 2024
Merged

fix: Off by one assertion for invoker property #216

merged 7 commits into from
Aug 4, 2024

Conversation

exaby73
Copy link
Contributor

@exaby73 exaby73 commented Jul 23, 2024

Fixes #182

@exaby73 exaby73 requested a review from cabljac July 23, 2024 10:03
cabljac
cabljac approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ushuz ushuz mentioned this pull request Aug 1, 2024
Closed
@exaby73 exaby73 merged commit e1c57d1 into main Aug 4, 2024
9 checks passed
@exaby73 exaby73 deleted the fix/off-by-one-assetion-invoker branch August 4, 2024 06:43
@sanninomed
Copy link

Hello, I would love to use new library version with this fix. When is going to be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ushuz ushuz ushuz approved these changes

@cabljac cabljac cabljac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot set invoker to public for HTTP request function
4 participants
@exaby73 @sanninomed @ushuz @cabljac